Remove the dotnetSdkInstallationEnabled feature flag by Copilot · Pull Request #14811 · dotnet/aspire

Copilot · 2026-02-28T19:11:24Z

Description

Users are responsible for acquiring .NET SDK. The CLI still fails fast when the required SDK version is absent, but no longer offers automatic download/installation.

Feature flag removal

Removed DotNetSdkInstallationEnabled from KnownFeatures.cs and both VS Code extension schemas

SDK installer simplification

IDotNetSdkInstaller: removed InstallAsync; CheckAsync returns (Success, HighestDetectedVersion, MinimumRequiredVersion) — dropped ForceInstall
DotNetSdkInstaller: removed InstallAsync, all install helpers, forceInstall/alwaysInstallSdk logic, private SDK dir check, unused constructor params (executionContext, dotNetCliRunner, logger)
SdkInstallHelper.EnsureSdkInstalledAsync: removed features and hostEnvironment params; now just checks and displays error on failure
SdkInstallResult / SdkCheckResult: pruned to AlreadyInstalled / NotInstalled

Runtime behavior

Removed DOTNET_ROLL_FORWARD=LatestMajor injection from DotNetCliRunner (only needed to support auto-installed SDKs)

Deleted files

src/Aspire.Cli/Resources/dotnet-install.sh
src/Aspire.Cli/Resources/dotnet-install.ps1
.github/workflows/update-dotnet-install-scripts.yml

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire.dev issue:
    - New issue
- No

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

centralus-2.in.applicationinsights.azure.com
- Triggering command: /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests --internal-msbuild-node /home/REDACTED/.local/share/fbbd10cf7c5c45b9a1742c769b8bd30c/.p --filter-not-trait category=failing --filter-not-trait quarantined=true --filter-not-trait outerloop=true (dns block)
- Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.deps.json /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Microsoft.DotNet.RemoteExecutor.dll Aspire.Cli.Tests, Version=42.42.42.42, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 Aspire.Cli.Tests.CliSmokeTests+<>c <LocaleOverrideReturnsExitCode>b__4_0 /tmp/bfvrwdhr.gc1 invalid-locale False ASPIRE_LOCALE_OVERRIDE (dns block)
- Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.deps.json /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Microsoft.DotNet.RemoteExecutor.dll Aspire.Cli.Tests, Version=42.42.42.42, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 Aspire.Cli.Tests.CliSmokeTests+<>c <LocaleOverrideReturnsExitCode>b__4_0 /tmp/bfvrwdhr.gc1 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove the dotnetSdkInstallationEnabled feature flag</issue_title>
<issue_description>We've decided that the user is responsible to acquiring .NET for C# based apphosts.</issue_description>

<agent_instructions>Users are responsible for acquiring .NET for C# apphosts. The CLI still fails fast when the required SDK version is absent, but no longer offers automatic download and installation.

Changes

Feature flag removal

Removed DotNetSdkInstallationEnabled from KnownFeatures.cs and both VS Code extension schemas

SDK installer simplification

IDotNetSdkInstaller: removed InstallAsync; CheckAsync now returns (Success, HighestDetectedVersion, MinimumRequiredVersion) (dropped ForceInstall)
DotNetSdkInstaller: removed InstallAsync, all install helpers, forceInstall/alwaysInstallSdk logic, private SDK dir check, and unused constructor params (executionContext, dotNetCliRunner, logger)
SdkInstallHelper.EnsureSdkInstalledAsync: removed features and hostEnvironment params; now just checks availability and displays an error on failure
SdkInstallResult / SdkCheckResult: pruned to AlreadyInstalled / NotInstalled only

Runtime behavior

Removed DOTNET_ROLL_FORWARD=LatestMajor injection from DotNetCliRunner (was needed only to support auto-installed SDKs)

Deleted files

src/Aspire.Cli/Resources/dotnet-install.sh
src/Aspire.Cli/Resources/dotnet-install.ps1
.github/workflows/update-dotnet-install-scripts.yml

Tests: updated TestDotNetSdkInstaller, SdkInstallHelperTests, DotNetSdkInstallerTests, and SdkInstallerTests to reflect the simplified interface.

Checklist

Is this feature complete?
- Yes. Ready to ship.
- No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
- Yes
- No
Did you add public API?
- Yes
  - If yes, did you have an API Review for it?
    - Yes
    - No
  - Did you add <remarks /> and <code /> elements on your triple slash comments?
    - Yes
    - No
- No
Does the change make any security assumptions or guarantees?
- Yes
  - If yes, have you done a threat model and had a security review?
    - Yes
    - No
- No
Does the change require an update in our Aspire docs?
- Yes
  - Link to aspire.dev issue:
    - New issue
- No

[!WARNING]

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

centralus-2.in.applicationinsights.azure.com

Triggering command: /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests --internal-msbuild-node /home/REDACTED/.local/share/b99a89f36da842919f541adcd0c83ae7/.p --filter-not-trait category=failing --filter-not-trait quarantined=true --filter-not-trait outerloop=true (dns block)

Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.deps.json /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Microsoft.DotNet.RemoteExecutor.dll Aspire.Cli.Tests, Version=42.42.42.42, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 Aspire.Cli.Tests.CliSmokeTests+<>c <LocaleOverrideReturnsExitCode>b__4_0 /tmp/v5ndm0io.1e4 invalid-locale False ASPIRE_LOCALE_OVERRIDE (dns block)

Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Aspire.Cli.Tests.deps.json /home/REDACTED/work/aspire/aspire/artifacts/bin/Aspire.Cli.Tests/Debug/net10.0/Microsoft.DotNet.RemoteExecutor.dll Aspire.Cli.Tests, Version=42.42.42.42, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51 Aspire.Cli.Tests.CliSmokeTests+<>c <LocaleOverrideReturnsExitCode>b__4_0 /tmp/v5ndm0io.1e4 (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled

Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent s...

Fixes Remove the dotnetSdkInstallationEnabled feature flag #14806

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

github-actions · 2026-02-28T19:31:33Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14811

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14811"

Copilot

Pull request overview

This PR removes the CLI’s automatic .NET SDK installation capability (and its feature flag), simplifying the SDK “installer” into a pure availability check while keeping the CLI fail-fast behavior when the required SDK isn’t present.

Changes:

Removed DotNetSdkInstallationEnabled feature flag (CLI + VS Code extension schemas) and deleted embedded dotnet-install scripts/workflow.
Simplified IDotNetSdkInstaller/DotNetSdkInstaller to only check for SDK availability (no install path).
Updated call sites and tests to reflect the new check-only behavior and telemetry outcomes.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/Aspire.Cli.Tests/Utils/SdkInstallHelperTests.cs	Updates tests for check-only flow and revised telemetry tags.
tests/Aspire.Cli.Tests/TestServices/TestDotNetSdkInstaller.cs	Updates test stub to the new `CheckAsync` tuple signature.
tests/Aspire.Cli.Tests/Templating/DotNetTemplateFactoryTests.cs	Adjusts template tests for updated `CheckAsync` return shape.
tests/Aspire.Cli.Tests/DotNetSdkInstallerTests.cs	Removes install-script expectations and updates checks to new tuple signature.
tests/Aspire.Cli.Tests/Commands/SdkInstallerTests.cs	Updates command tests to use the new `CheckAsync` tuple signature.
src/Aspire.Cli/Utils/SdkInstallResult.cs	Prunes enum values to reflect check-only outcomes.
src/Aspire.Cli/Utils/SdkInstallHelper.cs	Removes install UX; now only checks and displays an error on failure.
src/Aspire.Cli/Utils/SdkCheckResult.cs	Prunes enum values to reflect check-only outcomes.
src/Aspire.Cli/Utils/EnvironmentChecker/DotNetSdkCheck.cs	Updates to the new `CheckAsync` tuple signature.
src/Aspire.Cli/Templating/DotNetTemplateFactory.cs	Calls the simplified `EnsureSdkInstalledAsync` signature.
src/Aspire.Cli/Resources/dotnet-install.sh	Deleted (no longer embedding installer scripts).
src/Aspire.Cli/Resources/dotnet-install.ps1	Deleted (no longer embedding installer scripts).
src/Aspire.Cli/Projects/DotNetAppHostProject.cs	Updates SDK check calls prior to run/publish.
src/Aspire.Cli/NuGet/NuGetPackagePrefetcher.cs	Updates to the new `CheckAsync` tuple signature.
src/Aspire.Cli/KnownFeatures.cs	Removes the `dotnetSdkInstallationEnabled` feature definition/metadata.
src/Aspire.Cli/DotNet/IDotNetSdkInstaller.cs	Removes install API; `CheckAsync` now returns a 3-tuple.
src/Aspire.Cli/DotNet/DotNetSdkInstaller.cs	Deletes installation logic and simplifies constructor/dependencies.
src/Aspire.Cli/DotNet/DotNetCliRunner.cs	Removes `DOTNET_ROLL_FORWARD=LatestMajor` injection tied to auto-install.
src/Aspire.Cli/Commands/InitCommand.cs	Updates SDK check call site for new helper signature.
src/Aspire.Cli/Commands/ExecCommand.cs	Updates SDK check call site for new helper signature.
src/Aspire.Cli/Commands/AddCommand.cs	Updates SDK check call site for new helper signature.
src/Aspire.Cli/Aspire.Cli.csproj	Removes embedded resource entries for installer scripts.
extension/schemas/aspire-settings.schema.json	Removes `dotnetSdkInstallationEnabled` setting.
extension/schemas/aspire-global-settings.schema.json	Removes `dotnetSdkInstallationEnabled` setting.
.github/workflows/update-dotnet-install-scripts.yml	Deleted (no longer maintaining embedded scripts).

Comments suppressed due to low confidence (2)

tests/Aspire.Cli.Tests/Utils/SdkInstallHelperTests.cs:92

The test EnsureSdkInstalledAsync_WhenSdkMissing_DisplaysError no longer asserts that an error was actually displayed; it only checks telemetry tags. This makes the test name/intent misleading and leaves the user-facing error path unverified.

Set interactionService.DisplayErrorCallback to capture the message and assert it contains the minimum required version and the detected version.

    public async Task EnsureSdkInstalledAsync_WhenSdkMissing_DisplaysError()
    {
        using var fixture = new TelemetryFixture();

        var sdkInstaller = new TestDotNetSdkInstaller
        {
            CheckAsyncCallback = _ => (false, "8.0.100", "9.0.302")
        };

        var interactionService = new TestConsoleInteractionService();

        var result = await SdkInstallHelper.EnsureSdkInstalledAsync(
            sdkInstaller,
            interactionService,
            fixture.Telemetry);

        Assert.False(result);
        Assert.NotNull(fixture.CapturedActivity);

        var tags = fixture.CapturedActivity.Tags.ToDictionary(t => t.Key, t => t.Value);
        Assert.Equal("8.0.100", tags[TelemetryConstants.Tags.SdkDetectedVersion]);
        Assert.Equal("9.0.302", tags[TelemetryConstants.Tags.SdkMinimumRequiredVersion]);
        Assert.Equal("not_installed", tags[TelemetryConstants.Tags.SdkCheckResult]);
        Assert.Equal("not_installed", tags[TelemetryConstants.Tags.SdkInstallResult]);
    }

src/Aspire.Cli/Utils/SdkInstallResult.cs:19

SdkInstallResult is now documented as an “availability check”, but the type name still implies an installation result. With installation removed, this mismatch is easy to misread when maintaining telemetry/tagging code.

Consider renaming the enum to reflect the new behavior (or at least clarify in the XML doc that the name is retained for historical/telemetry reasons).

/// <summary>
/// Result of an SDK availability check.
/// </summary>
internal enum SdkInstallResult
{
    /// <summary>
    /// A valid SDK was already installed.
    /// </summary>
    AlreadyInstalled,

    /// <summary>
    /// The SDK is missing or does not meet the minimum required version.
    /// </summary>
    NotInstalled

src/Aspire.Cli/Commands/ExecCommand.cs

src/Aspire.Cli/Commands/InitCommand.cs

tests/Aspire.Cli.Tests/TestServices/TestDotNetSdkInstaller.cs

src/Aspire.Cli/DotNet/DotNetCliRunner.cs

github-actions · 2026-02-28T20:36:16Z

🎬 CLI E2E Test Recordings

The following terminal recordings are available for commit 2144011:

Test	Recording
AddPackageInteractiveWhileAppHostRunningDetached	▶️ View Recording
AddPackageWhileAppHostRunningDetached	▶️ View Recording
AgentCommands_AllHelpOutputs_AreCorrect	▶️ View Recording
AgentInitCommand_MigratesDeprecatedConfig	▶️ View Recording
AgentInitCommand_WithMalformedMcpJson_ShowsErrorAndExitsNonZero	▶️ View Recording
AspireUpdateRemovesAppHostPackageVersionFromDirectoryPackagesProps	▶️ View Recording
Banner_DisplayedOnFirstRun	▶️ View Recording
Banner_DisplayedWithExplicitFlag	▶️ View Recording
CreateAndDeployToDockerCompose	▶️ View Recording
CreateAndDeployToDockerComposeInteractive	▶️ View Recording
CreateAndPublishToKubernetes	▶️ View Recording
CreateAndRunAspireStarterProject	▶️ View Recording
CreateAndRunAspireStarterProjectWithBundle	▶️ View Recording
CreateAndRunJsReactProject	▶️ View Recording
CreateAndRunPythonReactProject	▶️ View Recording
CreateAndRunTypeScriptStarterProject	▶️ View Recording
CreateEmptyAppHostProject	▶️ View Recording
CreateStartAndStopAspireProject	▶️ View Recording
CreateStartWaitAndStopAspireProject	▶️ View Recording
CreateTypeScriptAppHostWithViteApp	▶️ View Recording
DescribeCommandResolvesReplicaNames	▶️ View Recording
DescribeCommandShowsRunningResources	▶️ View Recording
DetachFormatJsonProducesValidJson	▶️ View Recording
DoctorCommand_DetectsDeprecatedAgentConfig	▶️ View Recording
DoctorCommand_WithSslCertDir_ShowsTrusted	▶️ View Recording
DoctorCommand_WithoutSslCertDir_ShowsPartiallyTrusted	▶️ View Recording
LogsCommandShowsResourceLogs	▶️ View Recording
PsCommandListsRunningAppHost	▶️ View Recording
PsFormatJsonOutputsOnlyJsonToStdout	▶️ View Recording
SecretCrudOnDotNetAppHost	▶️ View Recording
SecretCrudOnTypeScriptAppHost	▶️ View Recording
StagingChannel_ConfigureAndVerifySettings_ThenSwitchChannels	▶️ View Recording
StopAllAppHostsFromAppHostDirectory	▶️ View Recording
StopAllAppHostsFromUnrelatedDirectory	▶️ View Recording
StopNonInteractiveMultipleAppHostsShowsError	▶️ View Recording
StopNonInteractiveSingleAppHost	▶️ View Recording
StopWithNoRunningAppHostExitsSuccessfully	▶️ View Recording

_{📹 Recordings uploaded automatically from CI run #22538430952}

davidfowl · 2026-03-01T00:05:21Z

This looks like an issue with JSON formatting:

Hex1b.Automation.WaitUntilTimeoutException : WaitUntil timed out after 00:08:20 waiting for: snapshot =>
            {
                var successPromptSearcher = new CellPatternSearcher()
                    .FindPattern(counter.Value.ToString())
                    .RightText(" OK] $ ");

                var result = successPromptSearcher.Search(snapshot);
                return result.Count > 0;
            }
  at Hex1bTestHelpers.cs:92
Terminal (160x48, cursor at 13,5, normal screen):
[10 OK] $ aspire run --detach --format json > output.json                                                                                                       
DOTNET_DbgEnableMiniDump is set and the createdump binary does not exist: createdump                                                                            
\ud83d\udd0d Finding apphosts...                                                                                                                                          
❌ An unexpected error occurred: The input does not contain any JSON tokens. Expected the input to start with a valid JSON token, when isFinalBlock is true.    
LineNumber: 0 | BytePositionInLine: 0.                                                                                                                          
[11 ERR:1] $                                                                                                                                                    
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                   at Hex1b.Automation.WaitUntilStep.ExecuteAsync(Hex1bTerminal terminal, Hex1bTerminalInputSequenceOptions options, CancellationToken ct) in /home/runner/work/hex1b/hex1b/src/Hex1b/Automation/WaitUntilStep.cs:line 39
   at Hex1b.Automation.Hex1bTerminalInputSequence.ApplyAsync(Hex1bTerminal terminal, CancellationToken ct) in /home/runner/work/hex1b/hex1b/src/Hex1b/Automation/Hex1bTerminalInputSequence.cs:line 41
   at Aspire.Cli.EndToEnd.Tests.MultipleAppHostTests.DetachFormatJsonProducesValidJson() in /_/tests/Aspire.Cli.EndToEnd.Tests/MultipleAppHostTests.cs:line 128
--- End of stack trace from previous location ---

### StdOut
Temporary workspace created at: /tmp/Aspire.Cli.Tests/TemporaryWorkspaces/d122d61b-905d-4f83-b8a9-26328c152456

src/Aspire.Cli/Utils/SdkInstallHelper.cs

… logic - Remove the dotnetSdkInstallationEnabled feature flag from KnownFeatures - Remove SDK auto-install prompting logic from SdkInstallHelper - Simplify EnsureSdkInstalledAsync to only check and report SDK availability - Remove unused fields from ExecCommand and InitCommand - Consolidate duplicate SdkCheckResult/SdkInstallResult enums into SdkCheckResult - Remove duplicate SdkInstallResult telemetry tag - Update tests accordingly Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

JamesNK · 2026-03-01T08:59:29Z

This looks like an issue with JSON formatting:

Hex1b.Automation.WaitUntilTimeoutException : WaitUntil timed out after 00:08:20 waiting for: snapshot =>
            {
                var successPromptSearcher = new CellPatternSearcher()
                    .FindPattern(counter.Value.ToString())
                    .RightText(" OK] $ ");

                var result = successPromptSearcher.Search(snapshot);
                return result.Count > 0;
            }
  at Hex1bTestHelpers.cs:92
Terminal (160x48, cursor at 13,5, normal screen):
[10 OK] $ aspire run --detach --format json > output.json                                                                                                       
DOTNET_DbgEnableMiniDump is set and the createdump binary does not exist: createdump                                                                            
\ud83d\udd0d Finding apphosts...                                                                                                                                          
❌ An unexpected error occurred: The input does not contain any JSON tokens. Expected the input to start with a valid JSON token, when isFinalBlock is true.    
LineNumber: 0 | BytePositionInLine: 0.                                                                                                                          
[11 ERR:1] $                                                                                                                                                    
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                
                                                                                                                                                                   at Hex1b.Automation.WaitUntilStep.ExecuteAsync(Hex1bTerminal terminal, Hex1bTerminalInputSequenceOptions options, CancellationToken ct) in /home/runner/work/hex1b/hex1b/src/Hex1b/Automation/WaitUntilStep.cs:line 39
   at Hex1b.Automation.Hex1bTerminalInputSequence.ApplyAsync(Hex1bTerminal terminal, CancellationToken ct) in /home/runner/work/hex1b/hex1b/src/Hex1b/Automation/Hex1bTerminalInputSequence.cs:line 41
   at Aspire.Cli.EndToEnd.Tests.MultipleAppHostTests.DetachFormatJsonProducesValidJson() in /_/tests/Aspire.Cli.EndToEnd.Tests/MultipleAppHostTests.cs:line 128
--- End of stack trace from previous location ---

### StdOut
Temporary workspace created at: /tmp/Aspire.Cli.Tests/TemporaryWorkspaces/d122d61b-905d-4f83-b8a9-26328c152456

What was the fix?

davidfowl · 2026-03-01T09:00:17Z

I re-ran it, which means there's a hidden bug with how we're setting the output

davidfowl · 2026-03-01T09:00:42Z

Filed this #14819

PR #14811 removed ForceInstall from IDotNetSdkInstaller.CheckAsync, changing from 4-element to 3-element tuple. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI assigned Copilot and davidfowl Feb 28, 2026

Copilot started work on behalf of davidfowl February 28, 2026 19:11 View session

Copilot AI changed the title ~~[WIP] Remove the dotnetSdkInstallationEnabled feature flag~~ Remove the dotnetSdkInstallationEnabled feature flag Feb 28, 2026

Copilot finished work on behalf of davidfowl February 28, 2026 19:31

davidfowl marked this pull request as ready for review February 28, 2026 19:31

Copilot AI review requested due to automatic review settings February 28, 2026 19:31

Copilot started reviewing on behalf of davidfowl February 28, 2026 19:32 View session

Copilot AI reviewed Feb 28, 2026

View reviewed changes

src/Aspire.Cli/Commands/ExecCommand.cs Show resolved Hide resolved

src/Aspire.Cli/Commands/InitCommand.cs Show resolved Hide resolved

tests/Aspire.Cli.Tests/TestServices/TestDotNetSdkInstaller.cs Outdated Show resolved Hide resolved

davidfowl requested review from mitchdenny and sebastienros February 28, 2026 20:08

davidfowl reviewed Feb 28, 2026

View reviewed changes

src/Aspire.Cli/DotNet/DotNetCliRunner.cs Show resolved Hide resolved

davidfowl requested a review from JamesNK March 1, 2026 00:04

davidfowl force-pushed the copilot/remove-dotnet-sdk-feature-flag branch from b2a84e0 to ab6ba2a Compare March 1, 2026 00:38

davidfowl mentioned this pull request Mar 1, 2026

MultipleAppHostTests failed: Check aspire run detach --format json does not bleed output to the command line #14819

Open

JamesNK reviewed Mar 1, 2026

View reviewed changes

src/Aspire.Cli/Utils/SdkInstallHelper.cs Outdated Show resolved Hide resolved

davidfowl force-pushed the copilot/remove-dotnet-sdk-feature-flag branch from ab6ba2a to 2144011 Compare March 1, 2026 07:19

JamesNK approved these changes Mar 1, 2026

View reviewed changes

davidfowl merged commit 67de873 into release/13.2 Mar 1, 2026
681 of 685 checks passed

davidfowl deleted the copilot/remove-dotnet-sdk-feature-flag branch March 1, 2026 09:00

dotnet-policy-service bot added this to the 13.2 milestone Mar 1, 2026

github-actions bot mentioned this pull request Mar 1, 2026

[13.2-burndown] Daily Burndown Report - March 1, 2026 #14825

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove the dotnetSdkInstallationEnabled feature flag#14811

Remove the dotnetSdkInstallationEnabled feature flag#14811
davidfowl merged 1 commit intorelease/13.2from
copilot/remove-dotnet-sdk-feature-flag

Copilot AI commented Feb 28, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2026 •

edited

Loading

Uh oh!

davidfowl commented Mar 1, 2026

Uh oh!

Uh oh!

JamesNK commented Mar 1, 2026

Uh oh!

davidfowl commented Mar 1, 2026

Uh oh!

davidfowl commented Mar 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

I tried to connect to the following addresses, but was blocked by firewall rules:

Changes

Checklist

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

github-actions bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎬 CLI E2E Test Recordings

Uh oh!

davidfowl commented Mar 1, 2026

Uh oh!

Uh oh!

JamesNK commented Mar 1, 2026

Uh oh!

davidfowl commented Mar 1, 2026

Uh oh!

davidfowl commented Mar 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Feb 28, 2026 •

edited

Loading

github-actions bot commented Feb 28, 2026 •

edited

Loading

github-actions bot commented Feb 28, 2026 •

edited

Loading